annotate lib/tmpfile-safer.c @ 11049:8398d9f607b4

unistd: guarantee STDIN_FILENO here, for OS/2 EMX * lib/unistd.in.h (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Guarantee a definition. * doc/posix-headers/unistd.texi (unistd.h): Document the bug. * modules/unistd-safer (Depends-on): Add dependency on unistd. * lib/c-stack.c (STDERR_FILENO): Rely on <unistd.h>. * lib/dup-safer.c (STDERR_FILENO): Likewise. * lib/execute.c (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Likewise. * lib/fd-safer.c (STDIN_FILENO, STDERR_FILENO): Likewise. * lib/fopen-safer.c (STDERR_FILENO): Likewise. * lib/pipe.c (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Likewise. * lib/tmpfile-safer.c (STDERR_FILENO): Likewise. * tests/test-posix_spawn1.c (STDIN_FILENO, STDOUT_FILENO) (STDERR_FILENO): Likewise. * tests/test-posix_spawn2.c (STDIN_FILENO, STDOUT_FILENO) (STDERR_FILENO): Likewise. * tests/test-posix_spawn3.c (STDIN_FILENO, STDOUT_FILENO) (STDERR_FILENO): Likewise. Reported by Elbert Pol. Signed-off-by: Eric Blake <ebb9@byu.net>
author Eric Blake <ebb9@byu.net>
date Mon, 19 Jan 2009 09:27:47 -0700 (2009-01-19)
parents bbbbbf4cd1c5
children e8d2c6fc33ad
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
1 /* Invoke tmpfile, but avoid some glitches.
11049
8398d9f607b4 unistd: guarantee STDIN_FILENO here, for OS/2 EMX
Eric Blake <ebb9@byu.net>
parents: 9309
diff changeset
2 Copyright (C) 2006, 2009 Free Software Foundation, Inc.
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
3
9309
bbbbbf4cd1c5 Change copyright notice from GPLv2+ to GPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 7302
diff changeset
4 This program is free software: you can redistribute it and/or modify
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
5 it under the terms of the GNU General Public License as published by
9309
bbbbbf4cd1c5 Change copyright notice from GPLv2+ to GPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 7302
diff changeset
6 the Free Software Foundation; either version 3 of the License, or
bbbbbf4cd1c5 Change copyright notice from GPLv2+ to GPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 7302
diff changeset
7 (at your option) any later version.
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
8
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
9 This program is distributed in the hope that it will be useful,
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
10 but WITHOUT ANY WARRANTY; without even the implied warranty of
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
11 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
12 GNU General Public License for more details.
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
13
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
14 You should have received a copy of the GNU General Public License
9309
bbbbbf4cd1c5 Change copyright notice from GPLv2+ to GPLv3+.
Bruno Haible <bruno@clisp.org>
parents: 7302
diff changeset
15 along with this program. If not, see <http://www.gnu.org/licenses/>. */
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
16
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
17 /* Written by Eric Blake, based on ideas from Paul Eggert. */
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
18
7302
8a1a9361108c * _fpending.c: Include <config.h> unconditionally, since we no
Paul Eggert <eggert@cs.ucla.edu>
parents: 7036
diff changeset
19 #include <config.h>
7036
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
20
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
21 #include "stdio-safer.h"
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
22
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
23 #include <errno.h>
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
24 #include <unistd.h>
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
25 #include "unistd-safer.h"
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
26
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
27 #include "binary-io.h"
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
28
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
29 /* Like tmpfile, but do not return stdin, stdout, or stderr.
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
30
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
31 Remember that tmpfile can leave files behind if your program calls _exit,
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
32 so this function should not be mixed with the close_stdout module. */
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
33
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
34 FILE *
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
35 tmpfile_safer (void)
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
36 {
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
37 FILE *fp = tmpfile ();
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
38
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
39 if (fp)
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
40 {
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
41 int fd = fileno (fp);
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
42
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
43 if (0 <= fd && fd <= STDERR_FILENO)
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
44 {
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
45 int f = dup_safer (fd);
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
46
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
47 if (f < 0)
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
48 {
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
49 int e = errno;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
50 fclose (fp);
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
51 errno = e;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
52 return NULL;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
53 }
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
54
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
55 /* Keep the temporary file in binary mode, on platforms
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
56 where that matters. */
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
57 if (fclose (fp) != 0
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
58 || ! (fp = fdopen (f, O_BINARY ? "wb+" : "w+")))
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
59 {
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
60 int e = errno;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
61 close (f);
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
62 errno = e;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
63 return NULL;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
64 }
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
65 }
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
66 }
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
67
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
68 return fp;
a57aa913b52c * tmpfile-safer.c: New file.
Eric Blake <ebb9@byu.net>
parents:
diff changeset
69 }