annotate m4/fcntl_h.m4 @ 12180:2c71cf09ef7e

Avoid symlink attack in localcharset module.
author Bruno Haible <bruno@clisp.org>
date Sun, 18 Oct 2009 16:58:39 +0200
parents 01c9ffd58a51
children e8d2c6fc33ad
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
12180
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
1 # serial 6
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
2 # Configure fcntl.h.
11007
f6cba5a556ce many *.m4 files: improve m4 quoting
Jim Meyering <meyering@redhat.com>
parents: 9299
diff changeset
3 dnl Copyright (C) 2006, 2007, 2009 Free Software Foundation, Inc.
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
4 dnl This file is free software; the Free Software Foundation
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
5 dnl gives unlimited permission to copy and/or distribute it,
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
6 dnl with or without modifications, as long as this notice is preserved.
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
7
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
8 dnl Written by Paul Eggert.
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
9
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
10 AC_DEFUN([gl_FCNTL_H],
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
11 [
11482
5ff04014c57f Tweak last commit.
Bruno Haible <bruno@clisp.org>
parents: 11479
diff changeset
12 AC_REQUIRE([gl_FCNTL_H_DEFAULTS])
12180
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
13 AC_REQUIRE([gl_FCNTL_O_FLAGS])
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
14 gl_CHECK_NEXT_HEADERS([fcntl.h])
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
15 FCNTL_H='fcntl.h'
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
16 AC_SUBST([FCNTL_H])
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
17 ])
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
18
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
19 # Test whether the flags O_NOATIME and O_NOFOLLOW actually work.
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
20 # Define HAVE_WORKING_O_NOATIME to 1 if O_NOATIME works, or to 0 otherwise.
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
21 # Define HAVE_WORKING_O_NOFOLLOW to 1 if O_NOFOLLOW works, or to 0 otherwise.
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
22 AC_DEFUN([gl_FCNTL_O_FLAGS],
2c71cf09ef7e Avoid symlink attack in localcharset module.
Bruno Haible <bruno@clisp.org>
parents: 12051
diff changeset
23 [
11482
5ff04014c57f Tweak last commit.
Bruno Haible <bruno@clisp.org>
parents: 11479
diff changeset
24 dnl Persuade glibc <fcntl.h> to define O_NOATIME and O_NOFOLLOW.
11479
2e168b9fc9aa Make fcntl module detect O_NOATIME, O_NOFOLLOW on GNU/Linux.
Ben Pfaff <blp@cs.stanford.edu>
parents: 11007
diff changeset
25 AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS])
11007
f6cba5a556ce many *.m4 files: improve m4 quoting
Jim Meyering <meyering@redhat.com>
parents: 9299
diff changeset
26 AC_CACHE_CHECK([for working fcntl.h], [gl_cv_header_working_fcntl_h],
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
27 [AC_RUN_IFELSE(
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
28 [AC_LANG_PROGRAM(
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
29 [[#include <sys/types.h>
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
30 #include <sys/stat.h>
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
31 #include <unistd.h>
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
32 #include <fcntl.h>
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
33 #ifndef O_NOATIME
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
34 #define O_NOATIME 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
35 #endif
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
36 #ifndef O_NOFOLLOW
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
37 #define O_NOFOLLOW 0
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
38 #endif
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
39 static int const constants[] =
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
40 {
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
41 O_CREAT, O_EXCL, O_NOCTTY, O_TRUNC, O_APPEND,
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
42 O_NONBLOCK, O_SYNC, O_ACCMODE, O_RDONLY, O_RDWR, O_WRONLY
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
43 };
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
44 ]],
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
45 [[
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
46 int status = !constants;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
47 {
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
48 static char const sym[] = "conftest.sym";
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
49 if (symlink (".", sym) != 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
50 || close (open (sym, O_RDONLY | O_NOFOLLOW)) == 0)
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
51 status |= 32;
12051
01c9ffd58a51 link-follow: ensure correct result
Eric Blake <ebb9@byu.net>
parents: 12047
diff changeset
52 unlink (sym);
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
53 }
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
54 {
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
55 static char const file[] = "confdefs.h";
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
56 int fd = open (file, O_RDONLY | O_NOATIME);
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
57 char c;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
58 struct stat st0, st1;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
59 if (fd < 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
60 || fstat (fd, &st0) != 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
61 || sleep (1) != 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
62 || read (fd, &c, 1) != 1
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
63 || close (fd) != 0
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
64 || stat (file, &st1) != 0
7687
7fcc949f763a * m4/fcntl_h.m4 (gl_FCNTL_H): Test the atime, not the mtime.
Paul Eggert <eggert@cs.ucla.edu>
parents: 7408
diff changeset
65 || st0.st_atime != st1.st_atime)
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
66 status |= 64;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
67 }
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
68 return status;]])],
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
69 [gl_cv_header_working_fcntl_h=yes],
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
70 [case $? in #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
71 32) gl_cv_header_working_fcntl_h='no (bad O_NOFOLLOW)';; #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
72 64) gl_cv_header_working_fcntl_h='no (bad O_NOATIME)';; #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
73 96) gl_cv_header_working_fcntl_h='no (bad O_NOATIME, O_NOFOLLOW)';; #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
74 *) gl_cv_header_working_fcntl_h='no';;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
75 esac],
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
76 [gl_cv_header_working_fcntl_h=cross-compiling])])
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
77
7408
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
78 case $gl_cv_header_working_fcntl_h in #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
79 *O_NOATIME* | no | cross-compiling) ac_val=0;; #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
80 *) ac_val=1;;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
81 esac
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
82 AC_DEFINE_UNQUOTED([HAVE_WORKING_O_NOATIME], [$ac_val],
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
83 [Define to 1 if O_NOATIME works.])
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
84
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
85 case $gl_cv_header_working_fcntl_h in #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
86 *O_NOFOLLOW* | no | cross-compiling) ac_val=0;; #(
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
87 *) ac_val=1;;
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
88 esac
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
89 AC_DEFINE_UNQUOTED([HAVE_WORKING_O_NOFOLLOW], [$ac_val],
e23b1333a117 [lib/ChangeLog]
Paul Eggert <eggert@cs.ucla.edu>
parents: 7362
diff changeset
90 [Define to 1 if O_NOFOLLOW works.])
7225
3307ae6ea2e5 * lib/fcntl_.h: New file.
Paul Eggert <eggert@cs.ucla.edu>
parents:
diff changeset
91 ])
9299
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
92
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
93 AC_DEFUN([gl_FCNTL_MODULE_INDICATOR],
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
94 [
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
95 dnl Use AC_REQUIRE here, so that the default settings are expanded once only.
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
96 AC_REQUIRE([gl_FCNTL_H_DEFAULTS])
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
97 GNULIB_[]m4_translit([$1],[abcdefghijklmnopqrstuvwxyz./-],[ABCDEFGHIJKLMNOPQRSTUVWXYZ___])=1
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
98 ])
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
99
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
100 AC_DEFUN([gl_FCNTL_H_DEFAULTS],
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
101 [
12047
21ec8b9a3f27 openat: fix openat bugs on Solaris 9
Eric Blake <ebb9@byu.net>
parents: 11966
diff changeset
102 GNULIB_OPEN=0; AC_SUBST([GNULIB_OPEN])
21ec8b9a3f27 openat: fix openat bugs on Solaris 9
Eric Blake <ebb9@byu.net>
parents: 11966
diff changeset
103 GNULIB_OPENAT=0; AC_SUBST([GNULIB_OPENAT])
9299
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
104 dnl Assume proper GNU behavior unless another module says otherwise.
12047
21ec8b9a3f27 openat: fix openat bugs on Solaris 9
Eric Blake <ebb9@byu.net>
parents: 11966
diff changeset
105 HAVE_OPENAT=1; AC_SUBST([HAVE_OPENAT])
21ec8b9a3f27 openat: fix openat bugs on Solaris 9
Eric Blake <ebb9@byu.net>
parents: 11966
diff changeset
106 REPLACE_OPEN=0; AC_SUBST([REPLACE_OPEN])
21ec8b9a3f27 openat: fix openat bugs on Solaris 9
Eric Blake <ebb9@byu.net>
parents: 11966
diff changeset
107 REPLACE_OPENAT=0; AC_SUBST([REPLACE_OPENAT])
9299
ada4d73c37a6 New module 'open'.
Bruno Haible <bruno@clisp.org>
parents: 8995
diff changeset
108 ])