Mercurial > hg > mercurial-crew

changeset 13412:58c497d0e44d

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
remove unnecessary list comprehensions These result lists were only built for the side effects, and so a normal loop is just as good and more straight-forward.
author Martin Geisler <mg@aragost.com>
date Thu, 03 Feb 2011 10:31:17 +0100
parents d4de90a612f7
children fa921dcd9993
files mercurial/context.py mercurial/ignore.py mercurial/localrepo.py
diffstat 3 files changed, 6 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -722,7 +722,8 @@
 
     def tags(self):
         t = []
-        [t.extend(p.tags()) for p in self.parents()]
+        for p in self.parents():
+            t.extend(p.tags())
         return t
 
     def children(self):
--- a/mercurial/ignore.py
+++ b/mercurial/ignore.py
@@ -86,7 +86,8 @@
                      (f, inst.strerror))
 
     allpats = []
-    [allpats.extend(patlist) for patlist in pats.values()]
+    for patlist in pats.values():
+        allpats.extend(patlist)
     if not allpats:
         return util.never
 
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1242,7 +1242,8 @@
                     self.ui.status(_("skipping missing subrepository: %s\n")
                                    % subpath)
 
-        [l.sort() for l in r]
+        for l in r:
+            l.sort()
         return r
 
     def heads(self, start=None):