Mercurial > hg > bts-webui

changeset 140:5f3713c1c547 draft

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ajax: minor nitpicks in the return order
author diegoe-guest
date Mon, 10 Aug 2009 23:41:25 +0000
parents cac0125db888
children 9fce97fb7498
files bts_webui/amancay/ajax.py
diffstat 1 files changed, 7 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/bts_webui/amancay/ajax.py
+++ b/bts_webui/amancay/ajax.py
@@ -1,5 +1,6 @@
 # vim: set sw=4 ts=4 sts=4 noet:
 from django.http import HttpResponse
+
 from amancay.bugs import handle_email
 
 def package_add(request):
@@ -18,11 +19,11 @@
 			return HttpResponse(status=500)
 	else:
 		packages = request.session.get('packages', [])
-		if package_name in packages:
-			return HttpResponse(status=500)
-		else:
+		if package_name not in packages:
 			request.session.get('packages', []).append(package_name)
 			return HttpResponse(status=200)
+		else:
+			return HttpResponse(status=500)
 
 def package_remove(request):
 	"""
@@ -62,11 +63,11 @@
 			return HttpResponse(status=500)
 	else:
 		bugs = request.session.get('bugs', [])
-		if bug_number in bugs:
-			return HttpResponse(status=500)
-		else:
+		if bug_number not in bugs:
 			request.session['bugs'].append(bug_number)
 			return HttpResponse(status=200)
+		else:
+			return HttpResponse(status=500)
 
 def bug_remove(request):
 	"""
@@ -103,7 +104,6 @@
 		action = 'unsubscribe'
 
 	if user.is_authenticated():
-		subscribe_email = request.user.email
 		to_address = ['%s-%s@bugs.debian.org' % (bug_number, action)]
 
 		# FIXME: this never tells us if the email left the building