changeset 2630:b9f40dce7763 draft

Reorganize(): remove spurious TxnAbort() If Reorganize() fails, then its caller, CBlock::SetBestChain(), will call TxnAbort(). Redundant TxnAbort() calls are harmless. The second will return an error return value, with no other side effects. TxnAbort() return values are generally never checked. The impact is nil.
author Jeff Garzik <jgarzik@exmulti.com>
date Mon, 14 May 2012 12:21:03 -0400 (2012-05-14)
parents 4e0ef5c9619a
children 04775a4029eb
files src/main.cpp
diffstat 1 files changed, 0 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1438,7 +1438,6 @@
         if (!block.ConnectBlock(txdb, pindex))
         {
             // Invalid block
-            txdb.TxnAbort();
             return error("Reorganize() : ConnectBlock %s failed", pindex->GetBlockHash().ToString().substr(0,20).c_str());
         }