# HG changeset patch # User rubidium # Date 1180596880 0 # Node ID f75a2f33287393fac661af788b66eb2b6c9bbea2 # Parent 90fd4a119369d0c77708ce21d9e727b5d1e38e3f (svn r9996) -Fix: be more strict when building/upgrading roads and/or road stops. diff --git a/src/road_cmd.cpp b/src/road_cmd.cpp --- a/src/road_cmd.cpp +++ b/src/road_cmd.cpp @@ -427,12 +427,16 @@ case MP_STATION: if (!IsDriveThroughStopTile(tile)) return CMD_ERROR; if (HASBIT(GetRoadTypes(tile), rt)) return_cmd_error(STR_1007_ALREADY_BUILT); + /* Don't allow "upgrading" the roadstop when vehicles are already driving on it */ + if (!EnsureNoVehicleOnGround(tile)) return CMD_ERROR; break; case MP_TUNNELBRIDGE: if ((IsTunnel(tile) && GetTunnelTransportType(tile) != TRANSPORT_ROAD) || (IsBridge(tile) && GetBridgeTransportType(tile) != TRANSPORT_ROAD)) return CMD_ERROR; if (HASBIT(GetRoadTypes(tile), rt)) return_cmd_error(STR_1007_ALREADY_BUILT); + /* Don't allow "upgrading" the bridge/tunnel when vehicles are already driving on it */ + if (!EnsureNoVehicleOnGround(tile)) return CMD_ERROR; break; default: diff --git a/src/station_cmd.cpp b/src/station_cmd.cpp --- a/src/station_cmd.cpp +++ b/src/station_cmd.cpp @@ -1273,6 +1273,9 @@ if (IsTileOwner(tile, OWNER_TOWN) && !_patches.road_stop_on_town_road) return_cmd_error(STR_DRIVE_THROUGH_ERROR_ON_TOWN_ROAD); if (GetRoadTileType(tile) != ROAD_TILE_NORMAL) return CMD_ERROR; + /* Don't allow building the roadstop when vehicles are already driving on it */ + if (!EnsureNoVehicleOnGround(tile)) return CMD_ERROR; + RoadTypes cur_rts = GetRoadTypes(tile); if (GetRoadOwner(tile, ROADTYPE_ROAD) != OWNER_TOWN && HASBIT(cur_rts, ROADTYPE_ROAD) && !CheckOwnership(GetRoadOwner(tile, ROADTYPE_ROAD))) return CMD_ERROR; if (HASBIT(cur_rts, ROADTYPE_TRAM) && !CheckOwnership(GetRoadOwner(tile, ROADTYPE_TRAM))) return CMD_ERROR;