Mercurial > hg > octave-shane > gnulib-hg
view lib/getugroups.c @ 12280:39be377f1765
getgroups: don't expose GETGROUPS_T to user
These days, most systems already declare getgroups with gid_t*.
But in the rare case that GETGROUPS_T is still int but gid_t
is short, the user should not have to uglify their code; let
the replacement hide all the magic.
Tested by configuring with ac_cv_type_getgroups=uint64_t on a
platform with 32-bit gid_t, and ignoring compiler warnings.
However, since we don't replace setgroups, the GETGROUPS_T
workaround is still needed there for now.
* lib/getgroups.c (rpl_getgroups): Change signature. Copy array
an element at a time if GETGROUPS_T is wrong size.
* lib/getugroups.h (getugroups): Change signature.
* lib/unistd.in.h (getgroups): Likewise.
* m4/getgroups.m4 (gl_FUNC_GETGROUPS): Use replacement if
signature needs fixing.
* m4/getugroups.m4 (gl_GETUGROUPS): No longer need
AC_TYPE_GETGROUPS.
* modules/group-member (Depends-on): Add getgroups.
* lib/group-member.c (group_info, get_group_info): Use gid_t.
(group_member): Rely on getgroups replacement.
* lib/getugroups.c (getugroups): Use gid_t.
* tests/test-getgroups.c (main): Likewise.
* NEWS: Mention the signature change.
* doc/posix-functions/getgroups.texi (getgroups): Mention the
problem with signature.
* doc/glibc-functions/setgroups.texi (setgroups): Mention that
GETGROUPS_T is still useful for setgroups.
Signed-off-by: Eric Blake <ebb9@byu.net>
author | Eric Blake <ebb9@byu.net> |
---|---|
date | Thu, 12 Nov 2009 10:19:39 -0700 |
parents | 6a41b8f5f874 |
children | e8d2c6fc33ad |
line wrap: on
line source
/* getugroups.c -- return a list of the groups a user is in Copyright (C) 1990, 1991, 1998-2000, 2003-2009 Free Software Foundation. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. */ /* Written by David MacKenzie. */ #include <config.h> #include "getugroups.h" #include <errno.h> #include <limits.h> #include <stdio.h> /* grp.h on alpha OSF1 V2.0 uses "FILE *". */ #include <string.h> #include <unistd.h> #if !HAVE_GRP_H /* Mingw lacks all things related to group management. The best we can do is fail with ENOSYS. */ int getugroups (int maxcount _UNUSED_PARAMETER_, gid_t *grouplist _UNUSED_PARAMETER_, char const *username _UNUSED_PARAMETER_, gid_t gid _UNUSED_PARAMETER_) { errno = ENOSYS; return -1; } #else /* HAVE_GRP_H */ # include <grp.h> # define STREQ(s1, s2) (strcmp (s1, s2) == 0) /* Like `getgroups', but for user USERNAME instead of for the current process. Store at most MAXCOUNT group IDs in the GROUPLIST array. If GID is not -1, store it first (if possible). GID should be the group ID (pw_gid) obtained from getpwuid, in case USERNAME is not listed in /etc/groups. Upon failure, set errno and return -1. Otherwise, return the number of IDs we've written into GROUPLIST. */ int getugroups (int maxcount, gid_t *grouplist, char const *username, gid_t gid) { int count = 0; if (gid != (gid_t) -1) { if (maxcount != 0) grouplist[count] = gid; ++count; } setgrent (); while (1) { char **cp; struct group *grp; errno = 0; grp = getgrent (); if (grp == NULL) break; for (cp = grp->gr_mem; *cp; ++cp) { int n; if ( ! STREQ (username, *cp)) continue; /* See if this group number is already on the list. */ for (n = 0; n < count; ++n) if (grouplist && grouplist[n] == grp->gr_gid) break; /* If it's a new group number, then try to add it to the list. */ if (n == count) { if (maxcount != 0) { if (count >= maxcount) goto done; grouplist[count] = grp->gr_gid; } if (count == INT_MAX) { errno = EOVERFLOW; goto done; } count++; } } } if (errno != 0) count = -1; done: { int saved_errno = errno; endgrent (); errno = saved_errno; } return count; } #endif /* HAVE_GRP_H */