diff top/maint.mk @ 17088:1ad5cd44b28f

maint.mk: teach sc_prohibit_magic_number_exit to accept 77 * top/maint.mk (sc_prohibit_magic_number_exit): Do not complain about uses like "exit (77)". "77" is automake's "skip this test" exit code. It is not in the same category as "exit (0)" or "exit (1)", and besides, I know of no symbolic name for that 77. Reported by Richard W.M. Jones in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
author Jim Meyering <meyering@redhat.com>
date Mon, 17 Sep 2012 11:34:44 +0200
parents ba92000376ad
children 60234c636185
line wrap: on
line diff
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -354,7 +354,7 @@
 #      perl -pi -e 's/(^|[^.])\b(exit ?)\(0\)/$1$2(EXIT_SUCCESS)/'
 sc_prohibit_magic_number_exit:
 	@prohibit='(^|[^.])\<(usage|exit|error) ?\(-?[0-9]+[,)]'	\
-	exclude='error ?\((0,|[^,]*)'					\
+	exclude='exit \(77\)|error ?\(((0|77),|[^,]*)'			\
 	halt='use EXIT_* values rather than magic number'		\
 	  $(_sc_search_regexp)