Mercurial > hg > octave-shane > gnulib-hg
annotate modules/mkstemps @ 17388:3c592b4deb04
utimensat-tests, etc.: try to fix some races
Problem reported by Bernhard Voelker in
<http://lists.gnu.org/archive/html/bug-gnulib/2013-04/msg00071.html>.
I don't know whether this patch fixes that race condition, but it
fixes *some* race conditions, so it should be a win.
* modules/chown-tests (Depends-on):
* modules/fchownat-tests (Depends-on):
* modules/fdutimensat-tests (Depends-on):
* modules/futimens-tests (Depends-on):
* modules/lchown-tests (Depends-on):
* modules/stat-time-tests (Depends-on):
* modules/utimens-tests (Depends-on):
* modules/utimensat-tests (Depends-on):
Depend on nanosleep, not usleep.
* modules/chown-tests (test_chown_LDADD):
* modules/lchown-tests (test_lchown_LDADD):
* modules/stat-time-tests (test_stat_time_LDADD):
New macro.
* modules/fchownat-tests (test_fchownat_LDADD):
* modules/fdutimensat-tests (test_fdutimensat_LDADD):
* modules/futimens-tests (test_futimens_LDADD):
* modules/utimens-tests (test_utimens_LDADD):
* modules/utimensat-tests (test_utimensat_LDADD):
Add $(LIB_NANOSLEEP).
* modules/stat-time-tests (Files): Add tests/nap.h.
* tests/nap.h: Include <limits.h>, for INT_MAX.
(lt_mtime): Remove.
(diff_timespec): New function.
(get_stat): Rename from get_mtime. All callers changed.
(nap_works): Determine the needed delay by inspecting the
file system's timestamp jumps; this should be more reliable.
Look at both mtime and ctime, and take the maximum of the two jumps.
(nap_works, guess_delay):
Return a nanosecond cound, not a microsecond count.
All callers changed.
(nap_works, nap): Use nanosleep, not usleep. Check for nanosleep
failure.
(nap): Multiply the guess by 1.125, to accommodate the case where
the file system's clock is a bit slower than nanosleep's clock.
* tests/test-stat-time.c (BASE): New macro.
Include nap.h.
(nap): Remove; nap.h now defines this. This removes a duplicate
implementation of 'nap'.
author | Paul Eggert <eggert@cs.ucla.edu> |
---|---|
date | Tue, 30 Apr 2013 23:14:19 -0700 |
parents | 51231c56c0a1 |
children |
rev | line source |
---|---|
12234 | 1 Description: |
2 mkstemps() function: create a private temporary file, with suffix | |
3 | |
4 Files: | |
5 lib/mkstemps.c | |
6 m4/mkstemps.m4 | |
7 | |
8 Depends-on: | |
14683
efab6978105e
Avoid unnecessary compilation units, through conditional dependencies.
Bruno Haible <bruno@clisp.org>
parents:
12235
diff
changeset
|
9 stdlib |
12234 | 10 extensions |
15474
51231c56c0a1
Add dependencies to the 'largefile' module.
Paul Eggert <eggert@cs.ucla.edu>
parents:
15052
diff
changeset
|
11 largefile |
14683
efab6978105e
Avoid unnecessary compilation units, through conditional dependencies.
Bruno Haible <bruno@clisp.org>
parents:
12235
diff
changeset
|
12 tempname [test $HAVE_MKSTEMPS = 0] |
12234 | 13 |
14 configure.ac: | |
15 gl_FUNC_MKSTEMPS | |
15052
248d56be0a25
mkstemps: Move AC_LIBOBJ invocations to module description.
Bruno Haible <bruno@clisp.org>
parents:
14683
diff
changeset
|
16 if test $HAVE_MKSTEMPS = 0; then |
248d56be0a25
mkstemps: Move AC_LIBOBJ invocations to module description.
Bruno Haible <bruno@clisp.org>
parents:
14683
diff
changeset
|
17 AC_LIBOBJ([mkstemps]) |
248d56be0a25
mkstemps: Move AC_LIBOBJ invocations to module description.
Bruno Haible <bruno@clisp.org>
parents:
14683
diff
changeset
|
18 fi |
12235
1441ddf44357
stdlib-safer: wrap all mkstemp variants
Eric Blake <ebb9@byu.net>
parents:
12234
diff
changeset
|
19 gl_MODULE_INDICATOR([mkstemps]) |
12234 | 20 gl_STDLIB_MODULE_INDICATOR([mkstemps]) |
21 | |
22 Makefile.am: | |
23 | |
24 Include: | |
25 <stdlib.h> | |
26 | |
27 License: | |
28 LGPLv2+ | |
29 | |
30 Maintainer: | |
31 Eric Blake |