Mercurial > hg > octave-nkf > gnulib-hg

changeset 17525:31bcf897b8c1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mgetgroups: remove dependency on realloc-gnu The dependency violates the comment in realloc-gnu, which says that tests can't depend on realloc-gnu; some tests depend on mgetgroups, so mgetgroups can't depend on realloc-gnu. Problem reported by Daniel Richard G. in <http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00056.html>. * lib/mgetgroups.c (mgetgroups): Don't call realloc (NULL, 0). * modules/mgetgroups (Depends-on): Depend on realloc-posix, not realloc-gnu.
author Paul Eggert <eggert@cs.ucla.edu>
date Sun, 13 Oct 2013 23:08:42 -0700
parents 01062b8ff04b
children 2f47c960f152
files ChangeLog lib/mgetgroups.c modules/mgetgroups
diffstat 3 files changed, 14 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2013-10-13  Paul Eggert  <eggert@cs.ucla.edu>
+
+	mgetgroups: remove dependency on realloc-gnu
+	The dependency violates the comment in realloc-gnu, which
+	says that tests can't depend on realloc-gnu; some tests depend
+	on mgetgroups, so mgetgroups can't depend on realloc-gnu.
+	Problem reported by Daniel Richard G. in
+	<http://lists.gnu.org/archive/html/bug-gnulib/2013-10/msg00056.html>.
+	* lib/mgetgroups.c (mgetgroups): Don't call realloc (NULL, 0).
+	* modules/mgetgroups (Depends-on): Depend on realloc-posix,
+	not realloc-gnu.
+
 2013-10-12  Paul Eggert  <eggert@cs.ucla.edu>
 
 	regex-tests: port to HP-UX 11.11
--- a/lib/mgetgroups.c
+++ b/lib/mgetgroups.c
@@ -133,7 +133,7 @@
       return -1;
     }
 
-  if (!username && gid != (gid_t) -1)
+  if (max_n_groups == 0 || (!username && gid != (gid_t) -1))
     max_n_groups++;
   g = realloc_groupbuf (NULL, max_n_groups);
   if (g == NULL)
--- a/modules/mgetgroups
+++ b/modules/mgetgroups
@@ -9,7 +9,7 @@
 Depends-on:
 getgroups
 getugroups
-realloc-gnu
+realloc-posix
 xalloc-oversized
 
 configure.ac: