Mercurial > hg > octave-nkf > gnulib-hg
view lib/se-selinux.in.h @ 15988:cd7ac59d8eb5
fts: close parent dir FD before returning from post-traversal fts_read
The problem: the fts-using "mkdir -p A/B; rm -rf A" would attempt to
unlink A, even though an FD open on A remained. This is suboptimal
(holding a file descriptor open longer than needed), but otherwise not
a problem on Unix-like kernels. However, on Cygwin with certain Novell
file systems, (see http://cygwin.com/ml/cygwin/2011-10/msg00365.html),
that represents a real problem: it causes the removal of A to fail
with e.g., "rm: cannot remove `A': Device or resource busy"
fts visits each directory twice and keeps a cache (fts_fd_ring) of
directory file descriptors. After completing the final, FTS_DP,
visit of a directory, RESTORE_INITIAL_CWD intended to clear the FD
cache, but then proceeded to add a new FD to it via the subsequent
FCHDIR (which calls cwd_advance_fd and i_ring_push). Before, the
final file descriptor would be closed only via fts_close's call to
fd_ring_clear. Now, it is usually closed earlier, via the final
FTS_DP-returning fts_read call.
* lib/fts.c (restore_initial_cwd): New function, converted from
the macro. Call fd_ring_clear *after* FCHDIR, not before it.
Update callers.
Reported by Franz Sirl via the above URL, with analysis by Eric Blake
in http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28739
author | Jim Meyering <meyering@redhat.com> |
---|---|
date | Sun, 23 Oct 2011 22:42:25 +0200 |
parents | 5f709022a256 |
children | 8250f2777afc |
line wrap: on
line source
/* Replacement <selinux/selinux.h> for platforms that lack it. Copyright (C) 2008-2011 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. */ #ifndef _@GUARD_PREFIX@_SELINUX_SELINUX_H # define _@GUARD_PREFIX@_SELINUX_SELINUX_H # if __GNUC__ >= 3 @PRAGMA_SYSTEM_HEADER@ # endif @PRAGMA_COLUMNS@ # if HAVE_SELINUX_SELINUX_H #@INCLUDE_NEXT@ @NEXT_SELINUX_SELINUX_H@ # else # include <sys/types.h> # include <errno.h> /* The definition of _GL_UNUSED_PARAMETER is copied here. */ # if !GNULIB_defined_security_types typedef unsigned short security_class_t; # define security_context_t char* # define is_selinux_enabled() 0 static inline int getcon (security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline void freecon (security_context_t con _GL_UNUSED_PARAMETER) {} static inline int getfscreatecon (security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int setfscreatecon (security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int matchpathcon (char const *file _GL_UNUSED_PARAMETER, mode_t m _GL_UNUSED_PARAMETER, security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int getfilecon (char const *file _GL_UNUSED_PARAMETER, security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int lgetfilecon (char const *file _GL_UNUSED_PARAMETER, security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int fgetfilecon (int fd, security_context_t *con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int setfilecon (char const *file _GL_UNUSED_PARAMETER, security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int lsetfilecon (char const *file _GL_UNUSED_PARAMETER, security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int fsetfilecon (int fd _GL_UNUSED_PARAMETER, security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int security_check_context (security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int security_check_context_raw (security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int setexeccon (security_context_t con _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int security_compute_create (security_context_t scon _GL_UNUSED_PARAMETER, security_context_t tcon _GL_UNUSED_PARAMETER, security_class_t tclass _GL_UNUSED_PARAMETER, security_context_t *newcon _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } static inline int matchpathcon_init_prefix (char const *path _GL_UNUSED_PARAMETER, char const *prefix _GL_UNUSED_PARAMETER) { errno = ENOTSUP; return -1; } # define GNULIB_defined_security_types 1 # endif # endif #endif /* _@GUARD_PREFIX@_SELINUX_SELINUX_H */