view tests/test-strerror.c @ 14895:66b65ce5da39

strerror_r-posix: fix on MacOS MacOS X 10.5 strerror(0) is "Unknown error: 0", which is not distinguished from "Unknown error: -1" for out-of-range. Worse, strerror_r(0,,) is "Undefined error: 0", although strerror_r for all other out-of-range values matches strerror. * m4/strerror.m4 (gl_FUNC_STRERROR): Flush out MacOS bug. * m4/strerror_r.m4 (gl_FUNC_STRERROR_R_WORKS): Likewise, and fix logic bug. * lib/strerror_r.c (strerror_r): Fix the bug. * lib/strerror.c (strerror): Likewise. * doc/posix-functions/strerror_r.texi (strerror_r): Document the problem. * doc/posix-functions/strerror.texi (strerror): Likewise. * doc/posix-functions/perror.texi (perror): Likewise. * tests/test-strerror.c (main): Enhance test. * tests/test-strerror_r.c (main): Likewise. Signed-off-by: Eric Blake <eblake@redhat.com>
author Eric Blake <eblake@redhat.com>
date Tue, 07 Jun 2011 20:49:04 -0600
parents 19cd3c889b58
children 8250f2777afc
line wrap: on
line source

/* Test of strerror() function.
   Copyright (C) 2007-2011 Free Software Foundation, Inc.

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 3, or (at your option)
   any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program; if not, write to the Free Software Foundation,
   Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.  */

/* Written by Eric Blake <ebb9@byu.net>, 2007.  */

#include <config.h>

#include <string.h>

#include "signature.h"
SIGNATURE_CHECK (strerror, char *, (int));

#include <errno.h>

#include "macros.h"

int
main (void)
{
  char *str;

  errno = 0;
  str = strerror (EACCES);
  ASSERT (str);
  ASSERT (*str);
  ASSERT (errno == 0);

  errno = 0;
  str = strerror (ETIMEDOUT);
  ASSERT (str);
  ASSERT (*str);
  ASSERT (errno == 0);

  errno = 0;
  str = strerror (EOVERFLOW);
  ASSERT (str);
  ASSERT (*str);
  ASSERT (errno == 0);

  /* POSIX requires strerror (0) to succeed.  Reject use of "Unknown
     error", but allow "Success", "No error", or even Solaris' "Error
     0" which are distinct patterns from true out-of-range strings.
     http://austingroupbugs.net/view.php?id=382  */
  errno = 0;
  str = strerror (0);
  ASSERT (str);
  ASSERT (*str);
  ASSERT (errno == 0);
  ASSERT (strstr (str, "nknown") == NULL);
  ASSERT (strstr (str, "ndefined") == NULL);

  /* POSIX requires strerror to produce a non-NULL result for all
     inputs; as an extension, we also guarantee a non-empty reseult.
     Reporting EINVAL is optional.  */
  errno = 0;
  str = strerror (-3);
  ASSERT (str);
  ASSERT (*str);
  ASSERT (errno == 0 || errno == EINVAL);

  return 0;
}