view m4/rename.m4 @ 12097:bb32464985d7

rename: fix another cygwin 1.5 bug Cygwin 1.5 sometimes, but not always, failed on rename("dir1","dir2") when "dir2" exists. Beef up the m4 tests to more reliably detect at least one of cygwin's bugs, in spite of not knowing why the rename only failed sporadically (thankfully, cygwin 1.7 does not have the bug). Meanwhile, although NetBSD needs to share the hard link workarounds, it does not need the trailing dot and directory workarounds, so split the m4 test into two separate feature checks. * m4/rename.m4 (gl_FUNC_RENAME): Split cygwin bugs into two checks. * lib/rename.c (rpl_rename): Don't penalize NetBSD with unnecessary cygwin workarounds. Also work around bug with moving full directory onto an empty one. * modules/rename (Depends-on): Add canonicalize-lgpl, rmdir. Signed-off-by: Eric Blake <ebb9@byu.net>
author Eric Blake <ebb9@byu.net>
date Thu, 01 Oct 2009 11:57:47 -0600
parents 1f43035b0900
children 18ce29e54b9f
line wrap: on
line source

# serial 20

# Copyright (C) 2001, 2003, 2005, 2006, 2009 Free Software Foundation, Inc.
# This file is free software; the Free Software Foundation
# gives unlimited permission to copy and/or distribute it,
# with or without modifications, as long as this notice is preserved.

dnl From Volker Borchert.
dnl Determine whether rename works for source file names with a trailing slash.
dnl The rename from SunOS 4.1.1_U1 doesn't.
dnl
dnl If it doesn't, then define RENAME_TRAILING_SLASH_BUG and arrange
dnl to compile the wrapper function.
dnl

AC_DEFUN([gl_FUNC_RENAME],
[
  AC_REQUIRE([AC_CANONICAL_HOST])
  AC_REQUIRE([gl_STDIO_H_DEFAULTS])

  dnl Solaris 10 mistakenly allows rename("file","name/").
  dnl NetBSD 1.6 mistakenly forbids rename("dir","name/").
  dnl The Solaris bug can be worked around without stripping
  dnl trailing slash, while the NetBSD bug requires stripping;
  dnl the two conditions can be distinguished by whether hard
  dnl links are also broken.
  AC_CACHE_CHECK([whether rename honors trailing slash on destination],
    [gl_cv_func_rename_slash_dst_works],
    [rm -rf conftest.f conftest.f1 conftest.d1 conftest.d2
    touch conftest.f && mkdir conftest.d1 ||
      AC_MSG_ERROR([cannot create temporary files])
    AC_RUN_IFELSE([AC_LANG_PROGRAM([[
#       include <stdio.h>
#       include <stdlib.h>
]], [if (rename ("conftest.f", "conftest.f1/") == 0) return 1;
     if (rename ("conftest.d1", "conftest.d2/") != 0) return 2;])],
      [gl_cv_func_rename_slash_dst_works=yes],
      [gl_cv_func_rename_slash_dst_works=no],
      dnl When crosscompiling, assume rename is broken.
      [gl_cv_func_rename_slash_dst_works="guessing no"])
    rm -rf conftest.f conftest.f1 conftest.d1 conftest.d2
  ])
  if test "x$gl_cv_func_rename_slash_dst_works" != xyes; then
    AC_LIBOBJ([rename])
    REPLACE_RENAME=1
    AC_DEFINE([RENAME_TRAILING_SLASH_DEST_BUG], [1],
      [Define if rename does not correctly handle slashes on the destination
       argument, such as on Solaris 10 or NetBSD 1.6.])
  fi

  dnl SunOS 4.1.1_U1 mistakenly forbids rename("dir/","name").
  dnl Solaris 9 mistakenly allows rename("file/","name").
  dnl These bugs require stripping trailing slash to avoid corrupting
  dnl symlinks with a trailing slash.
  AC_CACHE_CHECK([whether rename honors trailing slash on source],
    [gl_cv_func_rename_slash_src_works],
    [rm -rf conftest.f conftest.d1 conftest.d2
    touch conftest.f && mkdir conftest.d1 ||
      AC_MSG_ERROR([cannot create temporary files])
    AC_RUN_IFELSE([AC_LANG_PROGRAM([[
#       include <stdio.h>
#       include <stdlib.h>
]], [if (rename ("conftest.f/", "conftest.d2") == 0) return 1;
     if (rename ("conftest.d1/", "conftest.d2") != 0) return 2;])],
      [gl_cv_func_rename_slash_src_works=yes],
      [gl_cv_func_rename_slash_src_works=no],
      dnl When crosscompiling, assume rename is broken.
      [gl_cv_func_rename_slash_src_works="guessing no"])
    rm -rf conftest.f conftest.d1 conftest.d2
  ])
  if test "x$gl_cv_func_rename_slash_src_works" != xyes; then
    AC_LIBOBJ([rename])
    REPLACE_RENAME=1
    AC_DEFINE([RENAME_TRAILING_SLASH_SOURCE_BUG], [1],
      [Define if rename does not correctly handle slashes on the source
       argument, such as on Solaris 9 or cygwin 1.5.])
  fi

  dnl NetBSD 1.6 and cygwin 1.5.x mistakenly reduce hard link count
  dnl on rename("h1","h2").
  dnl This bug requires stat'ting targets prior to attempting rename.
  AC_CACHE_CHECK([whether rename manages hard links correctly],
    [gl_cv_func_rename_link_works],
    [rm -rf conftest.f conftest.f1
    if touch conftest.f && ln conftest.f conftest.f1 &&
        set x `ls -i conftest.f conftest.f1` && test "$2" = "$4"; then
      AC_RUN_IFELSE([AC_LANG_PROGRAM([[
#       include <stdio.h>
#       include <stdlib.h>
#       include <unistd.h>
]], [if (rename ("conftest.f", "conftest.f1")) return 1;
     if (unlink ("conftest.f1")) return 2;
     if (rename ("conftest.f", "conftest.f")) return 3;
     if (rename ("conftest.f1", "conftest.f1") == 0) return 4;])],
        [gl_cv_func_rename_link_works=yes],
        [gl_cv_func_rename_link_works=no],
        dnl When crosscompiling, assume rename is broken.
        [gl_cv_func_rename_link_works="guessing no"])
    else
      gl_cv_func_rename_link_works="guessing no"
    fi
    rm -rf conftest.f conftest.f1
  ])
  if test "x$gl_cv_func_rename_link_works" != xyes; then
    AC_LIBOBJ([rename])
    REPLACE_RENAME=1
    AC_DEFINE([RENAME_HARD_LINK_BUG], [1],
      [Define if rename fails to leave hard links alone, as on NetBSD 1.6
       or Cygwin 1.5.])
  fi

  dnl Cygwin 1.5.x mistakenly allows rename("dir","file").
  dnl mingw mistakenly forbids rename("dir1","dir2").
  dnl These bugs require stripping trailing slash to avoid corrupting
  dnl symlinks with a trailing slash.
  AC_CACHE_CHECK([whether rename manages existing destinations correctly],
    [gl_cv_func_rename_dest_works],
    [rm -rf conftest.f conftest.d1 conftest.d2
    touch conftest.f && mkdir conftest.d1 conftest.d2 ||
      AC_MSG_ERROR([cannot create temporary files])
    AC_RUN_IFELSE([AC_LANG_PROGRAM([[
#       include <stdio.h>
#       include <stdlib.h>
]], [if (rename ("conftest.d1", "conftest.d2") != 0) return 1;
     if (rename ("conftest.d2", "conftest.f") == 0) return 2;])],
      [gl_cv_func_rename_dest_works=yes],
      [gl_cv_func_rename_dest_works=no],
      dnl When crosscompiling, assume rename is broken.
      [gl_cv_func_rename_dest_works="guessing no"])
    rm -rf conftest.f conftest.d1 conftest.d2
  ])
  if test "x$gl_cv_func_rename_dest_works" != xyes; then
    AC_LIBOBJ([rename])
    REPLACE_RENAME=1
    AC_DEFINE([RENAME_DEST_EXISTS_BUG], [1],
      [Define if rename does not work when the destination file exists,
       as on Cygwin 1.5 or Windows.])
  fi
])