diff libinterp/corefcn/urlwrite.cc @ 20981:d27f66b4b8e6

maint: invert if/else/error instances. * oct-map.cc, oct-stream.cc, sparse-xpow.cc, symtab.h, typecast.cc, urlwrite.cc: Invert if/else/error instances.
author John W. Eaton <jwe@octave.org>
date Fri, 25 Dec 2015 00:48:01 -0500
parents a4f5da7c5463
children 936b88598a0b
line wrap: on
line diff
--- a/libinterp/corefcn/urlwrite.cc
+++ b/libinterp/corefcn/urlwrite.cc
@@ -185,11 +185,11 @@
 
     url_transfer obj (host, user, passwd, os);
 
-    if (obj.is_valid ())
-      handle_map[h] = obj;
-    else
+    if (! obj.is_valid ())
       error ("support for URL transfers was disabled when Octave was built");
 
+    handle_map[h] = obj;
+
     return h;
   }
 
@@ -259,21 +259,19 @@
     {
       iterator p = handle_map.find (h);
 
-      if (p != handle_map.end ())
-        {
-          // Curl handles are negative integers plus some random
-          // fractional part.  To avoid running out of integers, we
-          // recycle the integer part but tack on a new random part
-          // each time.
+      if (p == handle_map.end ())
+        error ("ch_manager::free: invalid object %g", h.value ());
 
-          handle_map.erase (p);
+      // Curl handles are negative integers plus some random
+      // fractional part.  To avoid running out of integers, we
+      // recycle the integer part but tack on a new random part
+      // each time.
 
-          if (h.value () < 0)
-            handle_free_list.insert
-             (std::ceil (h.value ()) - make_handle_fraction ());
-        }
-      else
-        error ("ch_manager::free: invalid object %g", h.value ());
+      handle_map.erase (p);
+
+      if (h.value () < 0)
+        handle_free_list.insert
+          (std::ceil (h.value ()) - make_handle_fraction ());
     }
 }