context: use a the nofsauditor when matching file in history (issue4749) Before this change, asking for file from history (eg: 'hg cat -r 42 foo/bar') could fail because of the current content of the working copy (eg: current "foo" being a symlink). As the working copy state have no influence on the content of the history, we can safely skip these checks. The working copy context class have a different 'match' implementation. That implementation still use the repo.auditor will still catch symlink traversal. I've audited all stuff calling "match" and they all go through a ctx in a sensible way. The most unclear case was diff which still seemed okay. You raised my paranoid level today and I double checked through tests. They behave properly. The odds of someone using the wrong (matching with a changectx for operation that will eventually touch the file system) is non-zero because you are never sure of what people will do. But I dunno if we can fight against that. So I would not commit to "never" for "at this level" and "in the future" if someone write especially bad code. However, as a last defense, the vfs itself is running path auditor in all cases outside of .hg/. So I think anything passing the 'matcher' for buggy reason would growl at the vfs layer.

+
−#!/usr/bin/env python
+
−#
+
−# Based on python's Tools/scripts/md5sum.py
+
−#
+
−# This software may be used and distributed according to the terms
+
−# of the PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2, which is
+
−# GPL-compatible.
+
−
+
−import sys, os
+
−
+
−try:
+
−    from hashlib import md5
+
−except ImportError:
+
−    from md5 import md5
+
−
+
−try:
+
−    import msvcrt
+
−    msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
+
−    msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
+
−except ImportError:
+
−    pass
+
−
+
−for filename in sys.argv[1:]:
+
−    try:
+
−        fp = open(filename, 'rb')
+
−    except IOError as msg:
+
−        sys.stderr.write('%s: Can\'t open: %s\n' % (filename, msg))
+
−        sys.exit(1)
+
−
+
−    m = md5()
+
−    try:
+
−        while True:
+
−            data = fp.read(8192)
+
−            if not data:
+
−                break
+
−            m.update(data)
+
−    except IOError as msg:
+
−        sys.stderr.write('%s: I/O error: %s\n' % (filename, msg))
+
−        sys.exit(1)
+
−    sys.stdout.write('%s  %s\n' % (m.hexdigest(), filename))
+
−
+
−sys.exit(0)