Mercurial > hg > hg-git
annotate CONTRIBUTING @ 828:fc63d0e2653d 0.7.0
setup: bump version for release
author | Augie Fackler <raf@durin42.com> |
---|---|
date | Wed, 05 Nov 2014 12:30:00 -0500 |
parents | b7eaa734e3b6 |
children | 427f26764fab |
rev | line source |
---|---|
756
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
1 The short version: |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
2 * Patches should have a good summary line for first line of commit message |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
3 * Patches should be sent to the Google Group[0] |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
4 * Patch needs to do exactly one thing |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
5 * testsuite passes |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
6 |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
7 The longer version: |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
8 |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
9 We use a variant of Mercurial's own contribution |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
10 system. http://mercurial.selenic.com/wiki/ContributingChanges contains |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
11 their full guidelines. Key differences are (by rule number): |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
12 |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
13 1. For hg-git, I'm not rigied about the "topic: a few words" format |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
14 for the first line, but I do insist on a sensible summary as the |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
15 first line of your commit |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
16 2. We don't require use of issueNNN for bug fixes (we have no robot) |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
17 3. Use the hg-git google group |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
18 10. We use mostly pep8 style. The current codebase is a mess, but new |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
19 code should be basically pep8. |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
20 |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
21 0: Pull requests are generally not noticed more than once every few |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
22 months. If you do a pull request, I'm still going to expect you to |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
23 have a clean history, and to be willing to rework history so it's |
7c7e296f8c1e
Add a file with contribution guidelines.
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
24 clean before I push the "merge" button. |