Mercurial > hg > bts-webui
changeset 69:47474c0d98a5 draft
bts_queries: PEP 8, style nitpicks
- CapWords-ify classes, PEP 8
- bts_queries: spaces after ','
| author | diegoe-guest |
|---|---|
| date | Wed, 03 Jun 2009 19:01:18 +0000 |
| parents | 4ed1928ff4b7 |
| children | ffc3e0915a98 |
| files | bts_webui/amancay/bts_queries.py bts_webui/amancay/bugs.py bts_webui/amancay/search.py bts_webui/amancay/tables.py bts_webui/amancay/toolbox.py bts_webui/amancay/views.py |
| diffstat | 6 files changed, 32 insertions(+), 28 deletions(-) [+] |
line wrap: on
line diff
--- a/bts_webui/amancay/bts_queries.py +++ b/bts_webui/amancay/bts_queries.py @@ -1,34 +1,35 @@ #!/usr/bin/python -class bts_queries: - ''' +class BtsQueries: + """ Abstract class implementing stubs for the required BTS queries the different implementations should support. - ''' + + """ def get_bugs_status(self, bug_numbers): - ''' + """ Returns an array with the status for all bug_numbers received. - ''' + """ pass def get_packages_bugs(self, packages): - ''' + """ Returns an array of bug numbers, for all received packages. - ''' + """ pass def get_submitters_bugs(self, emails): - ''' + """ Returns an array of bug numbers, for which the emails received are submitters. - ''' + """ pass def get_maintainers_bugs(self, emails): - ''' + """ Returns an array of bug numbers, for which the emails received are maintainers. - ''' + """ pass # ************************ SOAP Queries ***************************** @@ -41,10 +42,10 @@ # Import sets, for uniting lists of bugs from sets import Set -class soap_queries(bts_queries): - ''' - SOAP based bts_queries class. - ''' +class SoapQueries(BtsQueries): + """ + SOAP based BtsQueries class. + """ def __init__(self): self.url = 'http://bugs.debian.org/cgi-bin/soap.cgi' #self.url = 'http://bugs.donarmstrong.com/cgi-bin/soap.cgi' @@ -62,18 +63,19 @@ return self.__process_result(result) def get_packages_bugs(self, packages): - result = self.server.get_bugs("package",packages) + result = self.server.get_bugs('package', packages) return result def get_submitters_bugs(self, emails): - result = self.server.get_bugs("submitter", emails) + result = self.server.get_bugs('submitter', emails) return result def get_maintainers_bugs(self, emails): - result = self.server.get_bugs("maint",emails) + result = self.server.get_bugs('maint', emails) return result def get_all_packages_bugs(self, packages): + # FIXME: Not in BtsQueries pkg = self.server.get_bugs("package",packages) src = self.server.get_bugs("src",packages) # Unite this, and return the union. @@ -82,10 +84,12 @@ return list(result) def get_bug_log(self, bug): + # FIXME: Not in BtsQueries result = self.server.get_bug_log(bug) return result def get_tagged_bugs(self, users): + # FIXME: Not in BtsQueries # TODO: ask Don to allow many users at the same time result = {} for user in users:
--- a/bts_webui/amancay/bugs.py +++ b/bts_webui/amancay/bugs.py @@ -15,7 +15,7 @@ from django.utils import simplejson # Needed for SOAP -from bts_queries import soap_queries +from bts_queries import SoapQueries # Needed for sending emails from django.core.mail import send_mail @@ -33,9 +33,9 @@ info = process_bug_post(request, bug_number) user = request.user - queries = soap_queries() + queries = SoapQueries() bug_status = queries.get_bugs_status(bug_number)[0] - bug_originator = email.Utils.parseaddr(bug_status["originator"]) + bug_originator = email.Utils.parseaddr(bug_status['originator']) bug_log = queries.get_bug_log(bug_number) # Regular expressions to parse the mails
--- a/bts_webui/amancay/search.py +++ b/bts_webui/amancay/search.py @@ -16,8 +16,8 @@ from django.utils import simplejson # Needed for SOAP -from bts_queries import soap_queries, bug_sort -queries = soap_queries() +from bts_queries import SoapQueries, bug_sort +queries = SoapQueries() # Needed for timestamps, page calculation import time, math
--- a/bts_webui/amancay/tables.py +++ b/bts_webui/amancay/tables.py @@ -15,8 +15,8 @@ from django.utils import simplejson # Needed for SOAP -from bts_queries import soap_queries, bug_sort -queries = soap_queries() +from bts_queries import SoapQueries, bug_sort +queries = SoapQueries() # Toolboxes from toolbox import get_toolbox
--- a/bts_webui/amancay/toolbox.py +++ b/bts_webui/amancay/toolbox.py @@ -152,7 +152,7 @@ def package(request, package_name): user = request.user - queries = soap_queries() + queries = SoapQueries() bugs = queries.get_packages_bugs(package_name) bugs.sort(reverse=True)
--- a/bts_webui/amancay/views.py +++ b/bts_webui/amancay/views.py @@ -15,7 +15,7 @@ from django.utils import simplejson # Needed for SOAP -from bts_queries import soap_queries +from bts_queries import SoapQueries # Tables POST processing from tables import process_post, selected_bugs @@ -36,7 +36,7 @@ # Package page def package(request, package_name): user = request.user - queries = soap_queries() + queries = SoapQueries() bugs = queries.get_packages_bugs(package_name) bugs.sort(reverse=True)