# HG changeset patch # User diegoe-guest # Date 1249947696 0 # Node ID 9fce97fb7498204a7ae14cf9f631c4aa2f79e084 # Parent 5f3713c1c547b7624fde18b240970deb488c03a6 btsqueries: handle empty strings thrown by SOAP It looks like this is a bug in debbugs SOAP, we get a string consisting of a space or empty when there are no results to our query. diff --git a/bts_webui/amancay/btsqueries.py b/bts_webui/amancay/btsqueries.py --- a/bts_webui/amancay/btsqueries.py +++ b/bts_webui/amancay/btsqueries.py @@ -48,16 +48,19 @@ self.ns = 'Debbugs/SOAP' self.server = SOAPpy.SOAPProxy(self.url, self.ns) - def __process_result(self, result): + def get_bugs_status(self, bug_numbers): + result = self.server.get_status(bug_numbers) + + # FIXME: looks like a bug in debbugs SOAP implementation + # empty results turn out as "" or " " + if result == "" or result == " ": + return [] + if isinstance(result.item, list): return [item.value for item in result.item] else: return [result.item.value] - def get_bugs_status(self, bug_numbers): - result = self.server.get_status(bug_numbers) - return self.__process_result(result) - def get_packages_bugs(self, packages): result = self.server.get_bugs('package', packages) return result