Mercurial > hg > bts-webui

diff bts_webui/amancay/static/amancay_interface.js @ 144:c93c594f1f98 draft

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
toolbox: convert the toolbox into a template tag This is a *huge* improvement to how the code is organized right now. Specifically this gives us complete control over how stuff is loaded from the sidebar and makes more evident which are the paths taken by the code to actually do stuff. A concrete example is how loading of links happen. amancay_interface.js has been disabled to implement/move its functionality to other places.
author diegoe-guest
date Mon, 10 Aug 2009 23:42:03 +0000 (2009-08-10)
parents 3f5b51f6f99b
children
line wrap: on
line diff
--- a/bts_webui/amancay/static/amancay_interface.js
+++ b/bts_webui/amancay/static/amancay_interface.js
@@ -1,7 +1,6 @@
-
 function reload_current_view(evt) {
 	var view = document.getElementById("current_view").value;
-	load_bugs(evt,"/"+view+"_table/");
+	load_bugs(evt,"/" + view + "_table/");
 }
 
 var items_changed = function(request) {
@@ -37,33 +36,6 @@
 	reload_current_view();
 }
 
-var item_remove_failed = function (err) {
-  alert("The item/s could not be removed");
-  alert(err);
-};
-
-var item_add_failed = function (err) {
-  alert("The item could not be added");
-  alert(err);
-};
-
-var send_item_add = function (ev) {
-	ev.preventDefault();
-	var content = queryString([document.getElementById("item").name],
-	                          [document.getElementById("item").value]);
-	var d = doXHR("/index/?xhr=1", {"method": "post", "sendContent": content});
-	d.addCallbacks(items_changed, item_add_failed);
-	document.getElementById("item").value = "";
-}
-
-var send_item_selected = function (ev) {
-	ev.preventDefault();
-	item_name = document.getElementById("item").name+"_select";
-	table = document.getElementById("item_list");
-	var content = queryString(table);
-	var d = doXHR("/index/?xhr=1", {"method": "post", "sendContent": content});
-	d.addCallbacks(items_changed, item_remove_failed);
-}
 
 function loading_bugs() {
 		new_span = SPAN({'class': 'loading'}, "Loading...");
@@ -107,23 +79,6 @@
 	replaceChildNodes(document.getElementById("search_results"), new_span);
 	loading_finished();
 }
-var got_toolbox = function(request) {
-	place = document.getElementById("toolbox");
-	if (strip(request.responseText) != "") {
-		new_div = DIV();
-		new_div.innerHTML = request.responseText;
-		replaceChildNodes(place, new_div);
-		toolboxConnect();
-	} 
-	else {
-		new_span = SPAN({'class': 'error'}, "No toolbox");
-		replaceChildNodes(place, new_span);
-	}
-}
-var failed_toolbox = function(request) {
-	new_span = SPAN({'class': 'error'}, "ERROR: Unable to load toolbox");
-	replaceChildNodes(document.getElementById("toolbox"), new_span);
-}
 
 function load_bugs(evt, url) {
 	loading_bugs();
@@ -138,44 +93,6 @@
 	d.addCallbacks(got_search_results, failed_search_results);
 	evt.preventDefault();
 }
-function load_toolbox(url) {
-	var d = doXHR(url);
-	d.addCallbacks(got_toolbox, failed_toolbox);
-}
-
-function get_submitted_bugs(evt) {
-	load_toolbox("/submitted_bugs_toolbox/");
-	load_bugs(evt,"/submitted_bugs_table/");
-}
-function get_received_bugs(evt) {
-	load_toolbox("/received_bugs_toolbox/");
-	load_bugs(evt,"/received_bugs_table/");
-}
-function get_package_bugs(evt) {
-	load_toolbox("/package_bugs_toolbox/");
-	load_bugs(evt,"/package_bugs_table/");
-}
-function get_selected_bugs(evt) {
-	load_toolbox("/selected_bugs_toolbox/");
-	load_bugs(evt,"/selected_bugs_table/");
-}
-function get_tagged_bugs(evt) {
-	load_toolbox("/tagged_bugs_toolbox/");
-	load_bugs(evt,"/tagged_bugs_table/");
-}
-/*function get_search_form(evt) {
-	load_toolbox("/search_form_toolbox/");
-	load_bugs(evt,"/search_form/");
-}*/
-
-function toolboxConnect() {
-	var item_add = document.getElementById("add_item");
-	if (item_add)
-	    MochiKit.Signal.connect( item_add, 'onsubmit', send_item_add );
-	var item_selection = document.getElementById("item_selection");
-	if (item_selection)
-	    MochiKit.Signal.connect( item_selection, 'onsubmit', send_item_selected );
-}
 
 function send_page(evt) {
 	url = (evt.src() + "").replace(/search/, "search_table");
@@ -195,7 +112,6 @@
 
 function myLoadFunction()
 {
-	toolboxConnect();
 	pagerConnect();
 
 	if (buglogConnect)
@@ -224,4 +140,4 @@
 }
 
 /*connect our event handlers right off*/
-MochiKit.Signal.connect(window, "onload", myLoadFunction);
+MochiKit.DOM.addLoadEvent(myLoadFunction);