Mercurial > hg > bitcoin

changeset 1677:78fb81392446 draft

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Only remove database log files on shutdown after wallet encryption/rewrite
author Gavin Andresen <gavinandresen@gmail.com>
date Thu, 17 Nov 2011 14:21:32 -0500
parents 010b596b279e
children 8582bc930dae
files src/db.cpp src/db.h src/init.cpp src/wallet.cpp
diffstat 4 files changed, 16 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/src/db.cpp
+++ b/src/db.cpp
@@ -28,7 +28,12 @@
 static map<string, int> mapFileUseCount;
 static map<string, Db*> mapDb;
 
-static void EnvShutdown(bool fRemoveLogFiles)
+static bool fRemoveLogFiles = false;
+void RemoveLogFilesOnShutdown(bool fIn)
+{
+    fRemoveLogFiles = fIn;
+}
+static void EnvShutdown()
 {
     if (!fDbEnvInit)
         return;
@@ -71,7 +76,7 @@
     }
     ~CDBInit()
     {
-        EnvShutdown(false);
+        EnvShutdown();
     }
 }
 instance_of_cdbinit;
@@ -289,7 +294,7 @@
 }
 
 
-void DBFlush(bool fShutdown, bool fRemoveLogFiles)
+void DBFlush(bool fShutdown)
 {
     // Flush log data to the actual data file
     //  on all files that are not in use
@@ -322,7 +327,7 @@
             if (mapFileUseCount.empty())
             {
                 dbenv.log_archive(&listp, DB_ARCH_REMOVE);
-                EnvShutdown(fRemoveLogFiles);
+                EnvShutdown();
             }
         }
     }
--- a/src/db.h
+++ b/src/db.h
@@ -29,7 +29,8 @@
 extern DbEnv dbenv;
 
 
-extern void DBFlush(bool fShutdown, bool fRemoveLogFiles);
+extern void RemoveLogFilesOnShutdown(bool fRemoveLogFiles);
+extern void DBFlush(bool fShutdown);
 void ThreadFlushWalletDB(void* parg);
 bool BackupWallet(const CWallet& wallet, const std::string& strDest);
 
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -45,9 +45,9 @@
     {
         fShutdown = true;
         nTransactionsUpdated++;
-        DBFlush(false, false);
+        DBFlush(false);
         StopNode();
-        DBFlush(true, true);
+        DBFlush(true);
         boost::filesystem::remove(GetPidFile());
         UnregisterWallet(pwalletMain);
         delete pwalletMain;
--- a/src/wallet.cpp
+++ b/src/wallet.cpp
@@ -194,8 +194,8 @@
 
         // Need to completely rewrite the wallet file; if we don't, bdb might keep
         // bits of the unencrypted private key in slack space in the database file.
-        setKeyPool.clear();
-        CDB::Rewrite(strWalletFile);
+        if (CDB::Rewrite(strWalletFile))
+            RemoveLogFilesOnShutdown(true);
     }
 
     return true;
@@ -1134,6 +1134,7 @@
     {
         if (CDB::Rewrite(strWalletFile, "\x04pool"))
         {
+            RemoveLogFilesOnShutdown(true);
             setKeyPool.clear();
             // Note: can't top-up keypool here, because wallet is locked.
             // User will be prompted to unlock wallet the next operation